Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(translate): improve prompts to better support i18n suffixes #7167

Merged
merged 2 commits into from
Mar 25, 2025

Conversation

charIeszhao
Copy link
Member

@charIeszhao charIeszhao commented Mar 20, 2025

Summary

Improve AI prompt in the translate CLI tool, in order to better support i18n plural form suffixes.

Testing

Used in #7166. See differences in Arabic and Russian translations in phrases-experience package.

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

Sorry, something went wrong.

@charIeszhao charIeszhao requested a review from gao-sun as a code owner March 20, 2025 11:10
@charIeszhao charIeszhao self-assigned this Mar 20, 2025
@github-actions github-actions bot added enhancement Make it better size/s labels Mar 20, 2025
Copy link

github-actions bot commented Mar 20, 2025

COMPARE TO master

Total Size Diff 📈 +1.44 KB

Diff by File
Name Diff
.changeset/hungry-terms-smash.md 📈 +101 Bytes
packages/translate/src/prompts.ts 📈 +1.34 KB

@charIeszhao charIeszhao force-pushed the charles-improve-translate-cli-prompts branch from eff6306 to 7c999f6 Compare March 24, 2025 14:05
@charIeszhao charIeszhao changed the base branch from master to charles-language-tag-check-should-be-case-insensitive March 24, 2025 14:05
Base automatically changed from charles-language-tag-check-should-be-case-insensitive to master March 25, 2025 00:52
@charIeszhao charIeszhao force-pushed the charles-improve-translate-cli-prompts branch from 7c999f6 to e9c2b68 Compare March 25, 2025 01:16
@charIeszhao charIeszhao merged commit 552a368 into master Mar 25, 2025
37 checks passed
@charIeszhao charIeszhao deleted the charles-improve-translate-cli-prompts branch March 25, 2025 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Make it better size/s
Development

Successfully merging this pull request may close these issues.

None yet

3 participants