fix(console): fix sign-in method can not removed bug #7175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeng-li
requested review from
wangsijie,
charIeszhao,
xiaoyijun and
gao-sun
as code owners
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/console/src/pages/SignInExperience/PageContent/SignUpAndSignIn/SignInForm/SignInMethodEditBox/index.tsx | 📈 +784 Bytes |
| packages/console/src/pages/SignInExperience/PageContent/SignUpAndSignIn/SignUpForm/SignUpForm.tsx | 📈 +1.19 KB |
| packages/console/src/pages/SignInExperience/PageContent/SignUpAndSignIn/SignUpForm/SignUpIdentifiersEditBox/index.tsx | 📈 +1.54 KB |
| packages/integration-tests/src/tests/console/sign-in-experience/sign-up-and-sign-in/happy-path.test.ts | |
| packages/integration-tests/src/tests/console/sign-in-experience/sign-up-and-sign-in/helpers.ts | 📈 +2.46 KB |
simeng-li
changed the title
wangsijie
approved these changes
Mar 25, 2025
Base automatically changed from
simeng-log-10898-console-refactor-sign-up-and-sign-in-form
to
master
March 25, 2025 01:53
fix sign-in methods can't removed bug. Also add new integration tests
simeng-li
force-pushed
the
simeng-log-console-integration-tests
branch
from
9defd55 to
bc5a8e3
Compare
clean up legacy code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two console bug:
EmailOrPhone as a sign-up identifier incorrectly appends duplicate email and phone sign-in methods.Testing
New integration test cases added.
Checklist
.changeset