Skip to content

Move all @codemirror/* packages into peerDependencies #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

frenicohansen
Copy link

@frenicohansen frenicohansen commented Jun 27, 2025

This PR removes the Codemirror packages from direct dependencies and adds them under peerDependencies and devDependencies. By doing so, we ensure that consuming apps manage and install a single, shared instance of CodeMirror, preventing duplicate bundles, version mismatches, and unneeded package bloat.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @frenicohansen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request optimizes dependency management by moving CodeMirror-related packages to peerDependencies. This ensures that consuming applications handle CodeMirror dependencies, preventing duplication and version conflicts, ultimately reducing package bloat.

Highlights

  • Dependency Management: Moved @codemirror/* packages and codemirror from dependencies to peerDependencies in package.json.
  • Version Pinning: Pinned all @codemirror/* and codemirror peer dependencies to ^6.0.0.
  • Bundle Optimization: Ensured consuming apps manage a single instance of CodeMirror to prevent duplicate bundles and version mismatches.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly moves CodeMirror packages to peerDependencies, which is a good practice for a library. However, there are two key issues to address: the packages also need to be added to devDependencies to support local development, and the version range for the peer dependencies is too broad, which could cause compatibility issues for consumers. I've left detailed comments with suggestions to fix these.

@frenicohansen frenicohansen deleted the patch-1 branch June 27, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant