Fix logLevel not being applied in development environments#216
Merged
Fix logLevel not being applied in development environments#216
Conversation
WalkthroughRefactors logging resolver functions to consistently return LoggerOptions and separate configuration building from logger instantiation. Introduces and exports resolveLoggerConfiguration. Updates resolveLogger and resolveMonorepoLogger to use configuration builders. Test suite removes dev-environment test, renames a test, and retains remaining validation and redaction tests. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Caller
participant Resolver as resolveLogger
participant Builder as resolveLoggerConfiguration
participant Logger as Logger.create
Caller->>Resolver: resolveLogger(appConfig)
Resolver->>Builder: build LoggerOptions
Builder-->>Resolver: LoggerOptions
Resolver->>Logger: instantiate with LoggerOptions
Logger-->>Caller: Logger
note over Resolver,Builder: Configuration building separated from instantiation
sequenceDiagram
autonumber
actor Caller
participant Mono as resolveMonorepoLogger
participant MonoCfg as resolveMonorepoLoggerConfiguration
participant Logger as Logger.create
Caller->>Mono: resolveMonorepoLogger(appConfig)
Mono->>MonoCfg: build LoggerOptions
MonoCfg-->>Mono: LoggerOptions
Mono->>Logger: instantiate with LoggerOptions
Logger-->>Caller: Logger
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Comment |
CatchMe2
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue with logger configuration not resolving to a correct
logLevelfor non-productionenvironments.Summary by CodeRabbit
Refactor
Tests