Skip to content

Noop Observability Manager#250

Merged
kibertoad merged 8 commits intomainfrom
feat/noop-observability
Jan 19, 2026
Merged

Noop Observability Manager#250
kibertoad merged 8 commits intomainfrom
feat/noop-observability

Conversation

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Jan 19, 2026

Changes

This implementation is intended to use in cases where we explicitly want to disable observability while still satisfying requirements to have mandatory manager.

Checklist

  • Apply one of following labels; major, minor, patch or skip-release
  • I've updated the documentation, or no changes were necessary
  • I've updated the tests, or no changes were necessary

Summary by CodeRabbit

  • New Features

    • Added NoopObservabilityManager for observability management integration.
  • Documentation

    • Added Observability section to README with usage examples and available manager options.

✏️ Tip: You can customize this high-level summary in your review settings.

@kibertoad kibertoad requested review from a team, CarlosGamero and drdaemos as code owners January 19, 2026 10:29
@kibertoad kibertoad changed the title Feat/noop observability Noop Observability Manager Jan 19, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 19, 2026

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'tools'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

Introduces NoopObservabilityManager, a no-operation implementation of TransactionObservabilityManager with empty method implementations. The class is exported from the main index, documented in the README with usage examples, and excluded from test coverage.

Changes

Cohort / File(s) Change Summary
Documentation
README.md
Added Observability section describing TransactionObservabilityManager, MultiTransactionObservabilityManager, and NoopObservabilityManager with usage examples and navigation entry
Implementation
src/observability/NoopObservabilityManager.ts
New public class implementing TransactionObservabilityManager with no-op implementations of start(), startWithGroup(), stop(), and addCustomAttributes() methods
Exports
src/index.ts
Added public export for NoopObservabilityManager from observability module
Test Configuration
vitest.config.mts
Excluded new NoopObservabilityManager.ts file from test coverage

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: introducing a new NoopObservabilityManager class, which is the primary focus of this pull request.
Description check ✅ Passed The description follows the template structure with a Changes section explaining the purpose and a completed Checklist. All required sections are present and appropriately filled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@kibertoad kibertoad merged commit 193eb69 into main Jan 19, 2026
6 checks passed
@kibertoad kibertoad deleted the feat/noop-observability branch January 19, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants