fix: add length validation of tableData element to avoid TypeError

.github/workflows/pull_request.yml

@@ -7,7 +7,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 18.x
+          node-version: 20.x
           cache: 'yarn'
       - run: yarn
       - run: yarn lint
@@ -17,7 +17,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 18.x
+          node-version: 20.x
           cache: 'yarn'
       - run: yarn install &> /dev/null
       - run: yarn test
@@ -29,7 +29,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 18.x
+          node-version: 20.x
           cache: 'yarn'
       - run: yarn
       - run: yarn build:ci:clean

.vscode/settings.json

@@ -1,17 +1,10 @@
 {
   "typescript.tsdk": "node_modules/typescript/lib",
-  "eslint.autoFixOnSave": true,
   "eslint.validate": [
     "javascript",
     "javascriptreact",
-    {
-      "language": "typescript",
-      "autoFix": true
-    },
-    {
-      "language": "typescriptreact",
-      "autoFix": true
-    }
+    "typescript",
+    "typescriptreact"
   ],
   "editor.formatOnSave": true,
   "[javascript]": {
@@ -25,5 +18,8 @@
   },
   "[typescriptreact]": {
     "editor.formatOnSave": false
-  }
+  },
+  "editor.codeActionsOnSave": {
+    "source.fixAll.eslint": "always"
+  },
 }

dist/bundle.js.LICENSE.txt

@@ -5,9 +5,9 @@ object-assign
 */
 
 /*!
-  Copyright (c) 2018 Jed Watson.
-  Licensed under the MIT License (MIT), see
-  http://jedwatson.github.io/classnames
+	Copyright (c) 2018 Jed Watson.
+	Licensed under the MIT License (MIT), see
+	http://jedwatson.github.io/classnames
 */
 
 /*!

src/utils/LookmlDiagrammer/utils.ts

@@ -307,21 +307,24 @@ export function getJoinedViewsForViews(
       })
 
       const aIndex = aBaseObj.fieldIndex
-
       const bIndex = bBaseObj.fieldIndex
 
       const aName = diagramDict.tableData[a] ? a : explore.name
       const bName = diagramDict.tableData[b] ? b : explore.name
 
-      if (aIndex < bIndex) {
-        return -1
-      } else if (
-        aIndex === bIndex &&
-        diagramDict.tableData[aName].length <
-          diagramDict.tableData[bName].length
-      ) {
-        return -1
+      const aLength = diagramDict.tableData[aName]?.length ?? 0
+      const bLength = diagramDict.tableData[bName]?.length ?? 0
+
+      if (aIndex !== bIndex) {
+        if (aIndex === undefined) return 1
+        if (bIndex === undefined) return -1
+        return aIndex < bIndex ? -1 : 1
       }
+
+      if (aLength !== bLength) {
+        return aLength < bLength ? -1 : 1
+      }
+
       return 1
     })
     scaffold[viewName] = joined