Skip to content

Fix iOS AOT crash by removing Expression.Compile() from CreateContextFactory#94

Open
krzysztofkrak wants to merge 1 commit intoloresoft:mainfrom
krzysztofkrak:ios-fix
Open

Fix iOS AOT crash by removing Expression.Compile() from CreateContextFactory#94
krzysztofkrak wants to merge 1 commit intoloresoft:mainfrom
krzysztofkrak:ios-fix

Conversation

@krzysztofkrak
Copy link
Copy Markdown

Summary
This change fixes an iOS AOT/runtime compatibility issue in FluentValidator.

CreateContextFactory currently builds a delegate with Expression.Compile(). That works on Web and Android, but it can fail on iOS where the app runs in AOT-only mode and runtime code generation is restricted.

This PR replaces the compiled-expression factory with an AOT-safe reflection-based factory using Activator.CreateInstance(...).

Problem
When validation is triggered on field change, FluentValidator builds a ValidationContext through a cached factory.

The previous implementation used:
expression tree creation
lambda.Compile()

On iOS, that can crash with an error similar to:
Attempting to JIT compile method ... while running in aot-only mode

Root Cause
The issue is not in the validators themselves, but in the internal factory used to create ValidationContext instances.
The old implementation depends on runtime delegate generation, which is not safe in iOS AOT-only environments.

Fix
Replace the compiled-expression-based factory with a reflection-based implementation:

  • keep the same public behavior
  • keep the same caching shape
  • remove the dependency on Expression.Compile()
  • use Activator.CreateInstance(...) to construct ValidationContext

This avoids runtime code generation and makes the component safe for iOS AOT scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant