Fix iOS AOT crash by removing Expression.Compile() from CreateContextFactory#94
Open
krzysztofkrak wants to merge 1 commit intoloresoft:mainfrom
Open
Fix iOS AOT crash by removing Expression.Compile() from CreateContextFactory#94krzysztofkrak wants to merge 1 commit intoloresoft:mainfrom
krzysztofkrak wants to merge 1 commit intoloresoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change fixes an iOS AOT/runtime compatibility issue in FluentValidator.
CreateContextFactory currently builds a delegate with Expression.Compile(). That works on Web and Android, but it can fail on iOS where the app runs in AOT-only mode and runtime code generation is restricted.
This PR replaces the compiled-expression factory with an AOT-safe reflection-based factory using Activator.CreateInstance(...).
Problem
When validation is triggered on field change, FluentValidator builds a ValidationContext through a cached factory.
The previous implementation used:
expression tree creation
lambda.Compile()
On iOS, that can crash with an error similar to:
Attempting to JIT compile method ... while running in aot-only mode
Root Cause
The issue is not in the validators themselves, but in the internal factory used to create ValidationContext instances.
The old implementation depends on runtime delegate generation, which is not safe in iOS AOT-only environments.
Fix
Replace the compiled-expression-based factory with a reflection-based implementation:
This avoids runtime code generation and makes the component safe for iOS AOT scenarios.