fix(lemmatizer): predefined dict 타입 불일치 수정 (#261) - #268
Merged
Conversation
_initialize()가 str 키를 사용하여 lemma_candidate()의 (l, r) 튜플 조회에 매칭되지 않는 dead code 버그를 수정한다. - _predefined 키를 str에서 tuple[str, str]로 변경 - _predefined 값을 tuple[str, ...]에서 tuple[tuple[str, str], ...]로 변경 - lemma_candidate(), lemma_candidate_chat(), Lemmatizer.__init__() predefined 파라미터 타입 힌트 명확화 - predefined 루프 변수명 stem → stem_ending으로 의미 명확화 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- TestLemmatizer: candidates(), predefined 머징, predefined 활용 테스트 추가 - TestLemmaCandidatePredefined: predefined 키 튜플 구조 및 타입 일관성 테스트 추가 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced Mar 10, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_initialize()의_predefineddict가str키를 사용하여lemma_candidate()의(l, r)튜플 조회에 매칭되지 않는 dead code 버그 수정dict | None→dict[tuple[str, str], tuple[tuple[str, str], ...]] | Nonecandidates(), predefined 머징, predefined 활용, 타입 일관성Test plan
uv run pytest tests/unit/test_lemmatizer.py -v— 19 passedCloses #261
🤖 Generated with Claude Code