fix(normalizer): normalize() 함수를 PassCharacterNormalizer에 위임하도록 단순화 (#258) - #269
Merged
Conversation
normalize()가 module-level regex를 직접 사용하던 구현을 TextNormalizer.build_normalizer()로 위임하여 PassCharacterNormalizer와 일관된 처리 경로를 사용하도록 변경한다. - normalize() 내부 구현을 TextNormalizer.build_normalizer() 위임으로 교체 - normalize()에만 사용되던 module-level 패턴 3개 제거 (_number_pattern, _punctuation_pattern, _alphabet_pattern) - punctuation 파라미터는 symbol로 통합 (마이그레이션 가이드 docstring에 명시) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced Mar 10, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
normalize()내부 구현을TextNormalizer.build_normalizer()위임으로 교체해PassCharacterNormalizer와 일관된 처리 경로를 사용하도록 변경normalize()에만 사용되던 module-level 패턴 3개 제거 (_number_pattern,_punctuation_pattern,_alphabet_pattern)punctuation파라미터는symbol로 통합 (deprecated 함수이므로 동작 변경 허용, docstring에 명시)Test plan
uv run pytest tests/unit/test_normalizer.py -v— 15 passedCloses #258
🤖 Generated with Claude Code