refactor: PMI 함수를 soynlp.word에서 soynlp.utils로 이동 (#267) - #273
Merged
Conversation
- soynlp/utils/pmi.py: PMI 관련 함수(_as_diag, _logarithm_and_ppmi, pmi) 이동 - soynlp/utils/__init__.py: pmi를 public export에 추가 - soynlp/word/pmi.py: soynlp.utils.pmi를 deprecated re-export로 교체 (DeprecationWarning 포함, 하위 호환 유지) - tests/unit/test_pmi.py: soynlp.utils.pmi 기준으로 import 변경, deprecated 경로 경고 검증 테스트 추가 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced Mar 10, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
soynlp/utils/pmi.py신규 생성:_as_diag,_logarithm_and_ppmi,pmi함수 이동soynlp/utils/__init__.py:pmi를 public export에 추가soynlp/word/pmi.py:soynlp.utils.pmire-export +DeprecationWarning추가 (하위 호환 유지)tests/unit/test_pmi.py: 새 import 경로 기준으로 변경, deprecated 경로 경고 검증 테스트 추가Closes #267
Test plan
uv run pytest tests/unit/test_pmi.py— 3 passeduv run pre-commit run --all-files— all passed🤖 Generated with Claude Code