[otlib] move reset_delay from CLI argument to config file
#28512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RX clearing mechanism is implemented (in a slightly different improved way) in `target_reset` so it's okay to defer that to `reset_target(true)`. Signed-off-by: James Wainwright <[email protected]> (cherry picked from commit 839803e)
This allows us to have one function using a default configured reset and another one that allows specifying the reset. Signed-off-by: James Wainwright <[email protected]> (cherry picked from commit 4fcf745)
Signed-off-by: James Wainwright <[email protected]> (cherry picked from commit f8ba7c7)
Reset delays are now configured once in configuration files and cannot be changed per-test on the command line. This commit switches all uses of the `reset_target` function to use either `reset` or `reset_with_delay` where appropriate. All delays should be exactly the same after this commit. Signed-off-by: James Wainwright <[email protected]> (cherry picked from commit 472c31f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CLI flag is unused and we want to set a reset delay for whole platforms at a time (specifically for QEMU which requires a longer delay).
This PR:
reset_targetintoreset(which uses the configuration file) andreset_with_delaywhich accepts an ad hoc delay.The default is still
100msso behaviour should be unchanged.Backport of #28509