[topgen] Render address map of top #28516
Conversation
Signed-off-by: Robert Schilling <[email protected]>
| %> | ||
| ${mem_table_str} | ||
| % endif | ||
|
|
There was a problem hiding this comment.
Not a big deal, but I'd be inclined to drop this newline.
| % for addr_space in top['addr_spaces']: | ||
| ${"##"} ${addr_space['name'].capitalize()} Address Space | ||
|
|
||
| % if 'desc' in addr_space: |
There was a problem hiding this comment.
I always find these files quite difficult to read ("Give me more curly braces!!"). Sometimes, I've seen things that be slightly easier if they indent the stuff inside. So this line would be % if ... (gaining 2 spaces because it's inside the for loop). Definitely not a requirement, but I thought I'd suggest it.
|
We already have an automatically generated memory map here: https://opentitan.org/book/hw/top_earlgrey/doc/design/index.html?highlight=address%20map#memory-map The output is a bit different I guess but maybe it's better to modify the existing tool to make the register better, instead of creating a new one? |
|
Oh we have? We need to make that more prominent. Let me change that. |
|
Yes I agree it's a bit hidden at the moment, and also I prefer your new memory map to the old one so feel free to update the old python script and put the memory map somewhere else ;) |
3 participants
This PR adds a new template to automatically render the address map of a top to a dedicated file. The template will for all address spaces render the IP regions and the memory blocks into separate tables.
@adurbin-rivos This is what we couldn't find at some point in the documentation.