[silicon_creator,rescue] Various fixes related to USB and rescue tests #28521
+28
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interface numbers start at 0, using 1 is incorrect and may confuse the host. Signed-off-by: Amaury Pouly <[email protected]>
pamaury
requested review from
cfrantz and
timothytrippel
and removed request for
a team
Signed-off-by: Amaury Pouly <[email protected]>
pamaury
changed the title
pamaury
commented
Oct 20, 2025
| --exec="fpga clear-bitstream" | ||
| --exec="fpga load-bitstream {bitstream}" | ||
| --exec="bootstrap --clear-uart=true {firmware}" | ||
| --exec="console --non-interactive --timeout=100ms" |
There was a problem hiding this comment.
This improves slightly the output in case of error by making the console output available up until this point. I only did for this particular tests but this could be of interest in other tests
It is useful to display the console output during the test to debug problems. Signed-off-by: Amaury Pouly <[email protected]>
Signed-off-by: Amaury Pouly <[email protected]>
pamaury
force-pushed
the
fix_rescue_usb_config_desc
branch
from
6a26f14 to
35ff209
Compare
cfrantz
approved these changes
Oct 23, 2025
|
CI failure is unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.