-
Couldn't load subscription status.
- Fork 907
[crypto] Cryptolib versioning #28550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @pamaury for helping me with this. An optimization would be to get rid of the new |
|
Thx @nasahlpa and @pamaury. Do I understand correctly that the default and current behavior is that the version is a rolling / non-frozen / not pinned / not formally released one? Can we make that explicit somewhere, so that we can very clearly distinguish between in-development and released versions? |
854ff52 to
edbbace
Compare
Thanks for the remark, Andreas. Yes, the CL is currently not released, this is also mentioned in the documentation. I've added a comment to the version field. |
| #include "sw/device/lib/crypto/include/datatypes.h" | ||
|
|
||
| /** | ||
| * A truncated commit hash from the sw/device/lib/crypto directory from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to try exclude /data/crypto_testplan.hjson ? probably not possible I guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really sure how to do this TBH :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nasahlpa this is needed :)
edbbace to
c661a2d
Compare
This commit adds a versioning concept to the cryptolib. cryptolib_build_info_t contains: - released - is the CL version released or not? - version - pinned version of the CL - scm_revision_low/high - truncated commit hash of sw/device/lib/crypto Signed-off-by: Pascal Nasahl <[email protected]>
c661a2d to
5527190
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing my feedback, @nasahlpa. LGTM!
This commit adds a versioning concept to the cryptolib. cryptolib_build_info_t contains: