Development: Fix automatic pull request labeler CI action
#7749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-fein
force-pushed
the
dev-fixx-pr-labeller
branch
from
52b9256
to
791c893
Compare
b-fein
force-pushed
the
dev-fixx-pr-labeller
branch
from
791c893
to
c8ec013
Compare
b-fein
changed the title
Development: Fix automatic pull request labeler actionDevelopment: Fix automatic pull request labeler ci action
b-fein
force-pushed
the
dev-fixx-pr-labeller
branch
from
660d9be
to
eb9a53a
Compare
b-fein
force-pushed
the
dev-fixx-pr-labeller
branch
from
eb9a53a
to
dcfd1ad
Compare
This reverts commit dcfd1ad.
b-fein
force-pushed
the
dev-fixx-pr-labeller
branch
from
d1ad4ee
to
c455adb
Compare
Strohgelaender
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
pull_request_target uses the configuration from the base branch. I used #7779 to test the configuration and it seems to work.
Ceiridge
approved these changes
Dec 17, 2023
There was a problem hiding this comment.
The new changes follow the recommended syntax of the labeler, which looks fully correct: https://github.com/actions/labeler?tab=readme-ov-file#match-object
Therefore approved 👍
krusche
changed the title
Development: Fix automatic pull request labeler ci actionDevelopment: Fix automatic pull request labeler CI action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Motivation and Context
GitHub actions labeller introduced a new format for the configuration file.
https://github.com/actions/labeler/releases/tag/v5.0.0
Description
This PR updates the configuration file for the automatic pull request labeler action to the new format introduced with release 5.
It still fails on this branch since the configuration file from the
developbranch is always used. I updated the configuration file schema to follow the example in their readme (https://github.com/actions/labeler#basic-examples).Code Review