Restructured nightly_ts_version and added stand-alone details version.#83
Closed
craiglagegit wants to merge 4 commits intotickets/DM-54290from
Closed
Restructured nightly_ts_version and added stand-alone details version.#83craiglagegit wants to merge 4 commits intotickets/DM-54290from
craiglagegit wants to merge 4 commits intotickets/DM-54290from
Conversation
Adding DIQ histogram.
Several fixes and cosmetic improvements:
This ticket encompasses several fixes/improvements:
(1) There was an error in the way we were plotting the Zernikes, where the four corners were not being averaged properly. This is fixed.
(2) I have removed the edge CCDs which are outside the vignetted region from the ellipticity calculation
(3) Various cosmetic improvements, including:
(A) Adding a line on the FWHM vs Blur plot with FWHM = sqrt(Blur**2 + 0.4**2). Also, labeling both lines on this plot.
(B} Adding the median values to the system contribution histograms.
(C) Better labeling of ellipticity in top left plot.
Fixing typo in corr_lag calculation.
Corrected fix to corr_lag problem.
Contributor
Author
|
Closing. Something went wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many changes:
(1) Restructured the nightly_report_ts_version to drop the simplified report, and add an optional detailed report with full DOFs and Vmodes.
(2) Also added a stand-alone version of nightly_report_detailed to only do the detailed report.
(3) Corrected an error (in both versions) where the EFD queries were querying TAI times, so that they were 37 seconds or about one image off.
(4) Moved the Z4 dotted line from -0.20 to -0.15.
(5) Re-scaled the Zernikes using an algorithm from Aaron Roodman.
(6) Added a second y axis to the Zernikes in microns in addition to the existing y-axis in arcsec of FWHM.