CreateTab/AddNewTab - Allow passing of arguments#40
CreateTab/AddNewTab - Allow passing of arguments#40amaitland wants to merge 2 commits intolstratman:masterfrom
Conversation
- Allow passing of arguments (via params array) to CreateTab/AddNewTab - Simplify tabs example - Default to loading a simple 'Welcome To EasyTabs' message
Very minor code formatting changes.
|
I wanted to find something to nitpick about this PR, but it's an excellent, focused idea. The object param array gives complete flexibility to the data that can be passed in and pushes the implementation details to the overall implementing application, where they should be. An argument could be made for a generic type parameter controlling the type of this data, but it would be a crappy argument and I'm more in favor of the simplicity of this solution even at the (minor) cost of potential type correctness. So, with a couple of extremely minor code formatting corrections, I'd be happy to merge this PR. Thanks for the submission and the interest in the project! |
|
@lstratman By any chance did you get around to merging this PR? If so, would be great! |
Firstly, great to see the project is getting some love 👍 I regularly see people attempting to use
EasyTabs + CefSharp.This is more intended as a talking point on
How to pass arguments to a newly created tabthan it is the final product. Thoughts/comments/suggestions?