Various fixes and improvements #87
Conversation
--incompatible_allow_tags_propagation defaults to true and has for a while
.bazelrc_shared
Outdated
| @@ -15,6 +15,7 @@ build --verbose_failures | |||
| build --worker_max_instances=4 | |||
| build --worker_sandboxing | |||
|
|
|||
| common --incompatible_modify_execution_info_additive | |||
There was a problem hiding this comment.
Nit: Could we put this with the other --incompatible_* options?
rules/scalafmt/private/test.bzl
Outdated
| @@ -32,7 +32,7 @@ scala_non_default_format_attributes = { | |||
| def build_format(ctx): | |||
| files = [] | |||
| manifest_content = [] | |||
| config = ctx.toolchains["//rules/scalafmt:toolchain_type"].scalafmt_config.config | |||
| config = ctx.toolchains["@rules_scala_annex//rules/scalafmt:toolchain_type"].scalafmt_config.config | |||
There was a problem hiding this comment.
Is this necessary? Won't this label be evaluated in the context of this workspace?
There was a problem hiding this comment.
I believe you are correct. Revisiting this I'm pretty sure there was a bug with toolchain handling in the internal repo and I worked around it by doing this. Now that I've fixed the bug this is no longer necessary. I'll remove this change and the other change.
| @@ -15,7 +15,7 @@ _scalafmt_config = rule( | |||
| attrs = { | |||
| "config": attr.label( | |||
| allow_single_file = [".conf"], | |||
| default = "//:.scalafmt.conf", | |||
| default = "@rules_scala_annex//:.scalafmt.conf", | |||
There was a problem hiding this comment.
Wouldn't the correct thing to do be Label("//:.scalafmt.conf")? We can't guarantee the user of this module will name it rules_scala_annex.
| # We set `original_scala_toolchain_setting` so we can reset the toolchain to its | ||
| # original value in `scala_outgoing_transition`. That way, we can ensure every target is | ||
| # built under a single toolchain, thus preventing duplicate builds. | ||
| # | ||
| # We do not do this work when the toolchain name is set, but is no different than what is |
There was a problem hiding this comment.
It may be worth adding a comment explaining that this is a temporary fix.
Things I ran into while upgrading a large repo to Bazel 8 + bzlmod