Attempt to fix race conditions with non-atomic file copy for worker jars #90
+31
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were copying a file used by multiple threads directly to its destination. Problem is that copying is not an atomic action, so we could end up in states where the file wasn't correct when it was used. This should avoid that issue by first copying the file to a temp file and then using an atomic move to move the file to the destination used by other threads.
| Files.createDirectories(workerJar.getParent()) | ||
| Files.copy(workRequestJar, workerJar) | ||
| Files.move(tmpWorkerJar.get, workerJar, StandardCopyOption.ATOMIC_MOVE) |
There was a problem hiding this comment.
ATOMIC_MOVE: ... If the target file exists then it is implementation specific if the existing file is replaced or this method fails by throwing an IOException (documentation)
Do you know what happens on our systems? Does it replace or throw an error?
There was a problem hiding this comment.
I do not know. REPLACE_EXISTING is not set, so I'm hoping it would throw an error.
There was a problem hiding this comment.
That documentation also states for ATOMIC_MOVE:
The move is performed as an atomic file system operation and all other options are ignored.
so I don't think it matters if REPLACE_EXISTING is set or not, it may or may not throw an error.
jadenPete
approved these changes
Apr 8, 2025
|
Closing in favor of #91 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were copying a file used by multiple threads directly to its destination. Problem is that copying is not an atomic action, so we could end up in states where the file wasn't correct when it was used.
This should avoid that issue by first copying the file to a temp file and then using an atomic move to move the file to the destination used by other threads.