Skip to content

Conversation

@jefflembeck
Copy link
Contributor

@jefflembeck jefflembeck commented Oct 8, 2025

If your request body type has circular references, this causes a maximum call stack exceeded error. This change will fix that.

closes #1802

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues

Put closes #XXXX (where XXXX is the issue number) in your comment to auto-close the issue that your PR fixes.

Test plan

Tests cover the base case and also insure validation still works, even in those nested cases.

@jefflembeck
Copy link
Contributor Author

I have no idea why that test would fail here. It passes locally (node 18, 20, and 22 on macos)

@WoH
Copy link
Collaborator

WoH commented Oct 27, 2025

Can you rebase? CI should be green again

If your request body type has circular references, this causes a maximum
call stack exceeded error. This change will fix that.

closes lukeautry#1802
@jefflembeck jefflembeck force-pushed the circular-reference-issue branch from a8006fc to 26f9ebe Compare October 27, 2025 14:11
@jefflembeck
Copy link
Contributor Author

@WoH done! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validation creates stack errors when a request body type has a circular reference

2 participants