This repository was archived by the owner on Jan 16, 2018. It is now read-only.
Fix exists? and unset for groups, fix test running. #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix exists for groups
Author
|
The dependencies need locking down a lot more to be compatible with the old versions of ruby travis is building for, I don't know if I'll get time to work out which versions need locking too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes test running, adds a couple of tests for parsing.
Also fixes exists? not reporting true when a group is set, and unset not fully unsetting a group.
All changes have tests added for them, and since they are only bugs I've only bumped the patch version.
Also allows erb to be loaded, but wont break existing yaml loading.