Skip to content

Conversation

@lkirkwood
Copy link
Contributor

Adapted from #112.

@lkirkwood
Copy link
Contributor Author

Is there something that needs changing in this to get it reviewed?

@MarcusElg
Copy link

I also needed support for xs:all. I tried this pr and it did work as expected so it would be nice to get this merged :) @DmitrySamoylov

@DmitrySamoylov
Copy link
Contributor

Sorry for the delay. Please, add a test as described in https://github.com/lumeohq/xsd-parser-rs/blob/main/xsd-parser/tests/README.md

@DmitrySamoylov DmitrySamoylov self-requested a review March 12, 2024 11:36
@lkirkwood
Copy link
Contributor Author

I have added the tests as requested :)
Let me know if you need anything else for this

@DmitrySamoylov
Copy link
Contributor

Please, also run rustfmt ;) Not sure if you receive notifications for failed builds.

@lkirkwood
Copy link
Contributor Author

Apologies - fixed.

@DmitrySamoylov DmitrySamoylov merged commit 0834ded into lumeohq:main Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants