Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support building in windows #16

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

Jordan-Hall
Copy link
Contributor

@Jordan-Hall Jordan-Hall commented Mar 11, 2025

I've not sorted the actual build release because im unsure about the CI pipeline. But you should be able to check this out and run on windows.

#5 tested on windows - should be close for linux too

Signed-off-by: Jordan Hall <[email protected]>
Signed-off-by: Jordan Hall <[email protected]>
Signed-off-by: Jordan Hall <[email protected]>
Signed-off-by: Jordan Hall <[email protected]>
Signed-off-by: Jordan Hall <[email protected]>
Signed-off-by: Jordan Hall <[email protected]>
Signed-off-by: Jordan Hall <[email protected]>
Signed-off-by: Jordan Hall <[email protected]>
Signed-off-by: Jordan Hall <[email protected]>
@talisk
Copy link
Collaborator

talisk commented Mar 12, 2025

Thanks for your contribution. Very productive working! I will check it on Windows ASAP.

@Jordan-Hall
Copy link
Contributor Author

Thanks for your contribution. Very productive working! I will check it on Windows ASAP.

Thank you. I've had to change it to work for both compared to the working version the night before. So something could of slipped through due to caching

@Jordan-Hall
Copy link
Contributor Author

I've got my linux laptop tomorrow. I'll check it out but i think its no longer macos and windows. Looking at what i had to change, it should work on linux. Hence i've added linux build script

Copy link
Collaborator

@talisk talisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please write the building guide for windows in README?

@talisk
Copy link
Collaborator

talisk commented Mar 13, 2025

In your MR, can we get rid of WSL and use PowerShell with MinGW directly to build?

@Jordan-Hall
Copy link
Contributor Author

Could you please write the building guide for windows in README?

Sure i'll add that later today.

I assume you are referring to use of rm to delete? Sure i'll change these to native windows command. When i install git I override the command with unix. I dont actually use WSL on my machine

@neocarles
Copy link

Dear @Jordan-Hall how to fix this, i'm trying your's on windows and getting error

The system cannot find the path specified.
/d/lynx-devtool/packages/devtools-frontend-lynx
cp: cannot stat 'out/Default/gen/front_end/inspector.html': No such file or directory
sed: can't read output/inspector.html: No such file or directory
Error: Required files not found for packaging
 ELIFECYCLE  Command failed with exit code 1.
 ELIFECYCLE  Command failed with exit code 1.

@Jordan-Hall
Copy link
Contributor Author

Dear @Jordan-Hall how to fix this, i'm trying your's on windows and getting error

The system cannot find the path specified. /d/lynx-devtool/packages/devtools-frontend-lynx cp: cannot stat 'out/Default/gen/front_end/inspector.html': No such file or directory sed: can't read output/inspector.html: No such file or directory Error: Required files not found for packaging  ELIFECYCLE  Command failed with exit code 1.  ELIFECYCLE  Command failed with exit code 1.

Please accept my apologies. Needed to run pnpm install before the build. I've changed the setup.bat file. I've also changed the make file to do the same thing as it had the same issue (I copied order from that as i forgot exactly the order i got it to build in)

@Jordan-Hall Jordan-Hall mentioned this pull request Mar 22, 2025
@Jordan-Hall
Copy link
Contributor Author

{BFE2FF76-6981-41FF-8095-992F06597ADC}
@talisk sorry for the delay and lots of changes :/

First .sh files wont run on windows so made them in JS so it's cross platform.

Next gclient wouldn't run directly. Could used setx to add to path but thats then two workflows to run. Created a run gn to run the gclient from the path. Only way to work in windows.

@Jordan-Hall Jordan-Hall requested a review from talisk March 30, 2025 23:01
Comment on lines 44 to 45
"generate-protocol-resources": "python ./scripts/deps/generate_protocol_resources.py && git cl format --js",
"install-deps": "python ./scripts/deps/manage_node_deps.py",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a shebang in the top of these python file.

#!/usr/bin/env vpython

Therefore, we should not specify python commands explicitly.

https://chromium.googlesource.com/chromium/tools/depot_tools/master/vpython3

Maybe we should make sure that we can use vpython.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On windows using pnpm to run python script you cant just use the .py file. It requires to know what to use. I could do same as gclient and wrap it in JS to run. Alternative have a windows command. I cant see what actually calls these though on a search of the repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants