[WIP]: Adds streaming over WebSockets support #508
[WIP]: Adds streaming over WebSockets support #508p3javier wants to merge 1 commit intom1k1o:masterfrom
Conversation
- Updated base images in Dockerfile to use Go 1.23 and Node 18 (bookworm). - Added WebSocket streaming support in the client, including new methods for handling binary data and managing streaming modes. - Introduced a new WebSocket pipeline in the server for fMP4 streaming, with configuration options for video and audio codecs, bitrates, and fragment duration. - Enhanced the BaseClient to support streaming mode selection and improved error handling for WebSocket connections. - Updated Vue component to integrate WebSocket streaming features and manage state accordingly.
|
Quick question, why is the project still on nodejs 18 since the latest lts is 22, it is not the moment to update to it ? |
|
@Gauvino the whole client is pending a rewrite because Vue2 is EOL #358 and there is no simple way to upgrade, just rewrite basically from scratch. Its the next step on the roadmap. |
Thanks for the explanation and good luck re-creating the client |
Actually I think it will be more optimal switching to React for the new version instead of Vue 3. But this is not the thread and it is a decision that should be taken by the maintainer. |
|
@p3javier I am considering switching to react. |
|
@p3javier Yeah, mainly because I think is going to be easier to find React contributor than Vue contributors. Btw did you have opportunity to review the code I pushed? |
Yes, I look at. As a POC it looks good, but there are some changes needed prior this can be merged to the master:
I would say that the last point is the most important, as doubling the CPU usage is not what would be something that we want, if it can be avoided. |
I think you @m1k1o have way more context and experience with this project than me. I don't know if you can take on this. If I need to develop fully this feature is going to take me probably a couple months haha. |
|
@p3javier we could get this working as PoC as it, and then when it proves to be working good I can take on this and ensure that it integrates to the project. |
|
any chance this can be merged? |
This PR address the issue on #485