Skip to content

ci: align release draft workflow with rokt-widget pattern#34

Open
nickolas-dimitrakas wants to merge 5 commits into
mainfrom
ci/align-release-draft-workflow
Open

ci: align release draft workflow with rokt-widget pattern#34
nickolas-dimitrakas wants to merge 5 commits into
mainfrom
ci/align-release-draft-workflow

Conversation

@nickolas-dimitrakas
Copy link
Copy Markdown
Collaborator

@nickolas-dimitrakas nickolas-dimitrakas commented Apr 10, 2026

Background

The release draft workflow used peter-evans/create-pull-request without pinned action SHAs, no changelog generation, and the pull-request CI workflow only triggered on pull_request events. This meant CI did not run consistently across branches and the release PR lacked a changelog summary.

What Has Changed

  • Rewrote draft-release-publish.yml to align with the standard Rokt release draft pattern
  • Pinned all action SHAs for supply-chain security
  • Added changelog generation via ROKT/rokt-workflows/actions/generate-changelog with release notes included in the PR body
  • Upgraded peter-evans/create-pull-request to v8.1.0
  • Updated pull-request CI workflow triggers to pull_request + push on main and workstation/* branches
  • Bumped Xcode version to 26.2

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Reference Issue (For employees only. Ignore if you are an outside contributor)

  • Closes NO-JIRA

nickolas-dimitrakas and others added 3 commits April 10, 2026 14:00
Replace peter-evans/create-pull-request with manual git operations and
gh pr create using MP_SEMANTIC_RELEASE_BOT token, so the release PR is
opened as mparticle-automation rather than github-actions[bot] and
correctly triggers the pull-request CI workflow.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Use peter-evans/create-pull-request v8.1.0 with pinned SHA
- Add MP_SEMANTIC_RELEASE_BOT token so PR is opened as mparticle-automation
  rather than github-actions[bot], enabling CI to trigger on the release PR
- Add generate-changelog action and include release notes in PR body
- Pin action SHAs for supply-chain security
- Add patch as default bump-type

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
CI is triggered by the push event when peter-evans/create-pull-request
pushes the release branch, so no bot PAT is needed. Add workflow_dispatch
and push triggers on chore/release* branches to pull-request.yml to match
the pattern used in repos where this flow works.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@nickolas-dimitrakas nickolas-dimitrakas requested a review from a team as a code owner April 10, 2026 18:22
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 10, 2026

PR Summary

Medium Risk
Updates release-automation and CI workflow triggers/pinned actions; mistakes here could prevent release PR creation or break CI (notably the Xcode version change).

Overview
Updates the draft release workflow to a standardized “prepare release” flow: pins action SHAs, fetches full git history, bumps VERSION and the podspec version, generates release notes from git history, and opens a release PR against the current branch.

Extends the CI workflow to also run on pushes to main and workstation/*, and changes the configured XCODE_VERSION used by the test job.

Reviewed by Cursor Bugbot for commit e6a52d5. Bugbot is set up for automated code reviews on this repo. Configure here.

nickolas-dimitrakas and others added 2 commits April 10, 2026 14:24
Match the standard pattern: pull_request + push on main and workstation/*.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e6a52d5. Configure here.

push:
branches:
- main
- workstation/*
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing chore/release* push trigger defeats PR's stated purpose

High Severity

The push.branches trigger adds main and workstation/* but is missing chore/release*, which is the branch pattern that peter-evans/create-pull-request in draft-release-publish.yml creates (via branch: chore/release-${{ steps.bump-version.outputs.new_version }}). The PR description explicitly states the intent is to add chore/release* to bypass GitHub's restriction on GITHUB_TOKEN-created PRs not triggering pull_request events, but this pattern was omitted from the implementation. CI will still not fire on release PRs.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit e6a52d5. Configure here.

push:
branches:
- main
- workstation/*
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR-specific jobs lack guards for new push trigger

Medium Severity

The new push trigger causes pr-branch-check-name and pr-title-check jobs to run on push events (e.g., every merge to main), where no pull request context exists. These reusable workflows rely on PR data (github.event.pull_request) to check branch names and titles. Unlike pr-notify, which correctly guards with if: github.event_name == 'pull_request', these jobs have no such condition and will likely fail on every push-triggered run, creating persistent CI noise.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit e6a52d5. Configure here.

@nickolas-dimitrakas nickolas-dimitrakas self-assigned this Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants