fix(email): clean up reply draft when the body is emptied

[gbirman]

Emptying a reply's body left an empty draft behind because hasDraftContent counted the auto-derived reply recipients as content, so collectDraft never returned null and the draft was re-saved instead of deleted. The reply path now omits recipients from the content check (compose still counts user-entered recipients), so clearing a reply deletes its draft. Verified in-app: typing creates a draft, clearing the body removes it.

[macro-application]

[email] draft being created after opening reply input but not changing anything

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cc3c234b-45e7-45f2-9cb8-723ba57a105f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Walkthrough

In BaseInput.collectDraft(), the call to hasDraftContent no longer passes the sum of to, cc, and bcc recipient counts as an argument. Draft emptiness is now determined solely by body text, subject, and attachment count. A companion JSDoc update on hasDraftContent in prepareEmailBody.ts documents that reply/forward subjects alone do not constitute meaningful content and that the recipientCount parameter is intended only for user-entered compose recipients, not auto-derived reply recipients.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title follows conventional commits format with 'fix:' prefix, is under 72 characters (57 chars), and clearly describes the main change: preventing empty reply drafts from being saved.
Description check	✅ Passed	The description is directly related to the changeset, clearly explaining the bug (empty reply drafts being saved), the root cause (recipients counted as content), and the fix (omitting recipients from reply content check).
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Preview: https://gbirman-macro-2009-dont-save-e-2d71e2.preview.macro.com/app (f11caa9)