feat(doppler): connection gateway#4288
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe pull request migrates the 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@rust/cloud-storage/connection_gateway/src/main.rs`:
- Line 33: The code performs a separate Environment::new_or_prod() lookup on
line 55 to resolve macro_db_url, but ConfigLoader already loads the environment
from APP_SECRETS_JSON. This creates two divergent sources for environment
configuration. Remove the separate Environment::new_or_prod() call and instead
use the environment that was loaded by ConfigLoader to ensure macro_db_url is
resolved consistently from the same environment source that provided the
configuration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a23a4273-03b0-46b9-be47-5706cdb6fa9e
⛔ Files ignored due to path filters (1)
rust/cloud-storage/Cargo.lockis excluded by!**/*.lock,!**/Cargo.lock
📒 Files selected for processing (8)
.github/workspace-dep-closures.jsoninfra/stacks/connection-gateway/connection_gateway.tsinfra/stacks/connection-gateway/index.tsinfra/stacks/doppler-projects/index.tsrust/cloud-storage/connection_gateway/Cargo.tomlrust/cloud-storage/connection_gateway/src/config.rsrust/cloud-storage/connection_gateway/src/doppler_config.rsrust/cloud-storage/connection_gateway/src/main.rs
💤 Files with no reviewable changes (1)
- infra/stacks/connection-gateway/index.ts
No description provided.