Improve: Add Defensive Null Checks to uncompress2 #1080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello team,
This PR improves the robustness of the uncompress2 function by adding defensive parameter validation.
Currently, passing NULL for essential pointers like sourceLen or destLen will cause a segmentation fault. This change prevents this crash by adding checks at the beginning of the function.
If any parameter is invalid, the function now returns Z_STREAM_ERROR, providing the caller with a clear and actionable error instead of a crash. This behavior is consistent with the library's conventions for handling invalid arguments.
I believe this makes the function safer and easier to debug for developers. Happy to address any feedback.
Thank you for your time and consideration.