fix: allow skus with ':'s

[adamzero1]

Description (*)

When running bin/magento inventory:reservation:create-compensations if the sku contains ':' the regex breaks, and then the entities can't be loaded.
BEFORE

AFTER FIX

Fixed Issues (if relevant)

Manual testing scenarios (*)

This is difficult as it requires you to have a reservation inconsistency for a product with a sku with a ';' in it. But if this is the case simply run:
php bin/magento inventory:reservation:create-compensations
(with the compensation string)
You will get error like: "Get EntityId on null"

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] fix: allow skus with ':'s #3438: fix: allow skus with ':'s

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento create issue

[engcom-Hotel]

Hello @adamzero1,

Thanks for the contribution!

Please fix the failed integration test, other functional test failures seems flaky to me, hence re-running the build.

Thanks

[engcom-Hotel]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

[engcom-Hotel]

Hello @adamzero1,

As we are unable to get ay response from your side, we are picking this PR for integration test failures fixes.

Thanks for the contribution.

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run Integration Tests, Static Tests

[engcom-Hotel]

@magento run Integration Tests, Static Tests

[engcom-Hotel]

@magento run all tests

[ihor-sviziev]

@adamzero1 Could you clarify the use case for having a colon (:) in a SKU?

From my experience, SKUs typically use a dash (-) as the separator. Given that, I’m not sure Magento should support colons - it seems like an uncommon pattern and could introduce issues across different parts of the system.

Do you have a specific scenario in mind where a colon is necessary?

[engcom-Hotel]

Hello @adamzero1,

Have you got a chance to look into this #3404 (comment)?

Thank you

[engcom-Hotel]

Hello @adamzero1,

We appreciate your contribution!

Since we haven't received a response from you for an extended period, we are closing this PR for now.

Whenever you're ready to resume work on this, please feel free to reopen it or request us to do so. We'll be more than happy to assist you.

Thanks once again!