Skip to content

Exception #0 (ReflectionException) issue fixed #39819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from
Open

Exception #0 (ReflectionException) issue fixed #39819

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1d5964
Exception #0 (ReflectionException) issue fixed
Sathakathulla-S Apr 15, 2025
90343e1
Merge branch '2.4-develop' into 38480-Exception-#0-ReflectionException
engcom-Hotel May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/code/Magento/Eav/Model/Entity/Attribute/AbstractAttribute.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,11 @@ public function getSource()
} else {
$this->_source = $this->getSourceModel();
}
$source = $this->_universalFactory->create($this->_source);
try {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align the try-catch block for better readability.

$source = $this->_universalFactory->create($this->_source);
} catch (\ReflectionException $e) {
$source = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using false, consider returning null to indicate the absence of a valid source object.

}
if (!$source) {
throw new LocalizedException(
__(
Expand Down