⚡ perf: use getSize() in Order hasInvoices/hasShipments/hasCreditmemos

[lbajsarowicz]

Summary

• Replace full collection loading in hasInvoices(), hasShipments(), and hasCreditmemos() with getSize() which uses SQL COUNT(*) instead of loading all rows into memory.
• Each method previously called ->count() on the collection, which triggers load() and hydrates all entities just to check existence.

Call Site Analysis

Investigated all call sites to confirm getSize() is a net positive:

Method	Call Sites	Standalone Boolean	Guard + Load	Verdict
hasInvoices()	3	1 (canEdit())	2 (AddressUpdate, DHL)	NET POSITIVE
hasShipments()	2	2 (OrderCancellation)	0	NET POSITIVE
hasCreditmemos()	0 external	-	-	NET POSITIVE

• Majority (3/5) are standalone boolean checks that never need the collection
• For guard+load sites: when count=0 (most orders), saves full collection load; when count>0, adds trivial COUNT before the cached collection load
• Collection is cached in $this->_invoices etc., so subsequent getInvoiceCollection() calls return cached result regardless

Performance Impact

Metric	Before	After
hasInvoices()	Loads all invoice rows via Collection::count() → load()	Single SELECT COUNT(*) via getSize()
hasShipments()	Same pattern	Same fix
hasCreditmemos()	Same pattern	Same fix

Test Plan

• Unit tests added covering all 3 methods with DataProvider (6 test cases)
• Tests assert getSize() called once, count() never called, load() never called
• PHPCS clean (requires CI validation)
• PHPStan clean (requires CI validation)

Ref: #40704

⭐ Support my work

Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.

Learn more at https://github.com/sponsors/lbajsarowicz

[m2-assistant]

Hi @lbajsarowicz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[lbajsarowicz]

@magento run all tests