Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Caching Headers #73

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

manishparanjape
Copy link

Fix for #52

@tjwiebell
Copy link
Contributor

@manishparanjape - Thank you for this submission, it really helped track down some odd symptoms we saw with Fastly in the cloud. These missing headers were not only causing content to not be edge cached, but also broke gzip compression/encoding in the process.

While I don't think we want to open up header injection, we do want to enforce this best practice of cache control. We're struggling to think of a use case why this would need to be extensible, but wanted to check with you. Can you think of a reason we shouldn't just append a year long cache-control header if one is not already present?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants