feat: add ephemeral flag#29
Merged
Merged
Conversation
WalkthroughAdds an ephemeral flag to AccountSharedData (EPHEMERAL_FLAG_INDEX) with getter/setter and Debug output, exposes ACCOUNT_STATIC_SIZE, moves and expands tests into a new crate-level tests module, removes an internal test module from cow.rs, and applies non-functional formatting to Cargo.toml. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3257dec to
dfa756e
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/lib.rs`:
- Around line 43-44: The build fails because the declared test module mod
cow_tests; in lib.rs has no corresponding src/cow_tests.rs or
src/cow_tests/mod.rs; either add the missing test file containing the cow_tests
module (with its tests) or remove the stray declaration from lib.rs (the line
"mod cow_tests;") to resolve the E0583 error; locate the declaration in lib.rs
and perform one of those two fixes depending on whether the tests were moved or
omitted.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/lib.rs`:
- Around line 43-44: There is a duplicate tests module: the new external
declaration `mod tests;` conflicts with the existing inline `#[cfg(test)] pub
mod tests { ... }`; fix by removing or renaming the inline module (e.g., change
`pub mod tests` to `pub mod inline_tests` or move its contents into the new
`src/tests.rs`) and ensure only one `tests` module exists, keeping the external
`mod tests;` as the canonical test module while updating any test references
accordingly.
dfa756e to
6eae52b
Compare
7 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Tests
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.