Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed type of message for Toast.show function. #150

Closed
wants to merge 1 commit into from
Closed

Fixed type of message for Toast.show function. #150

wants to merge 1 commit into from

Conversation

AndreasA
Copy link

Relates: #123

@AndreasA AndreasA mentioned this pull request Nov 26, 2021
Open
@AndreasA
Copy link
Author

I just found there is annother PR that fixes the type and does some additional stuff regarding ReactNode. #111

not sure, if the additional stuff is necessary or not because ReactNode seems to already work correctly, except the type, which is why I keep this PR open until feedback by maintainers

Pipe-Runner
Pipe-Runner approved these changes Jan 16, 2022
View reviewed changes
Copy link

@Pipe-Runner Pipe-Runner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems correct.

@gaufranc
Copy link

Can we merge this? thanks

@AndreasA AndreasA closed this by deleting the head repository Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkWissler MarkWissler MarkWissler approved these changes

@Pipe-Runner Pipe-Runner Pipe-Runner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndreasA @gaufranc @MarkWissler @Pipe-Runner