fix: fix hyper-text animation logic #597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hannnnxiiii is attempting to deploy a commit to the product-studio Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks man, your code was pretty helpful! |
…o hx/fix-hyper-text
|
Could you please approve my pull request? I'm looking forward to contributing to you all! ^^ |
|
@hannnnxiiii ty for this! Merging now |
|
Thank god!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old animation logic may cause the playback time to be greater than the duration when the string is too long.
Assume that a string has a length of 50 and duration is set to 1000, then the callback function will be executed 500 times! On the one hand, it causes performance waste, and on the other hand, the callback function queue + execution time is greater than 2ms, resulting in the animation completion time being much greater than the duration.