Fix barrellist sort with multiple lists #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mahmoud merged 1 commit into mahmoud:master from Matthieu-Beauchamp:master

Oct 4, 2025

Contributor

Matthieu-Beauchamp commented Oct 4, 2025

The following code in BarrelList.sort causes a crash

del self.lists[:]
self.lists[0] = tmp_sorted


          Fix barrellist sort with multiple lists

4653c74

mahmoud merged commit f9c4f30 into mahmoud:master

10 checks passed

Owner

mahmoud commented Oct 4, 2025

Nice fix, with a test, no less. LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet