Sharp fit

[seb-celinedesign]

Add the new Sharp fit parameter as a configuration option. Replace the deprecated max parameter.

[StarpTech]

Hi @CelineDesign, could you add a test?

[seb-celinedesign]

Hi, just add the fit option in the config object and a test for it.
Is that what you wanted ?

[StarpTech]

I mean a test that guarantees the correct output.

[StarpTech]

The default option is centre https://sharp.pixelplumbing.com/api-resize#resize that change would be breaking.

[seb-celinedesign]

I think you're mistaking. According to the documentation the "fit" parameter default value is "cover". See here :
https://sharp.pixelplumbing.com/api-resize#resize
Centre is the "position" param default value.

[seb-celinedesign]

I mean a test that guarantees the correct output.

By "correct output" do you mean the file at the right dimension ?
Because none of the current test is testing the generated image file and his properties. I think the role of gulp-responsive is to pass correct params to the Sharp library, which is the one who manipulate image files.