Allow @ember/test-waiters@4. Addon dependency maintenance #2953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`silent-error` and `ember-cli-is-package-missing` were only used in the blueprints, which were removed in the v2 addon conversion.
This release is API compatible, so we can widen the range.
BobrImperator
force-pushed
the
dependency-maintenance
branch
from
a34c95b to
deb8a4c
Compare
|
Note: #2954 introduces a change that requires Ember 4.1.0 >= . This PR requests support of test-waiters v4 which also have dropped support of Ember < v4 |
This was referenced Mar 21, 2025
Merged
BobrImperator
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
silent-errorandember-cli-is-package-missingsince they are no longer used@ember/test-waitersv4 which allows apps to use v4 without using overrides