Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/qa_training/domain/service_make_features.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def _make_y(

def _handle_missing_values(self, df_customer_info) -> pd.DataFrame:
"""欠損値処理する."""
df_customer_info["Age"] = df_customer_info["Age"].fillna(10)
df_customer_info["Age"] = df_customer_info["Age"].fillna(20)
df_customer_info["Cabin"] = df_customer_info["Cabin"].fillna("S")
df_customer_info = df_customer_info.dropna()
return df_customer_info
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
PassengerId,Survived,Pclass,Name,Sex,Age,SibSp,Parch,Ticket,Fare,Cabin,Embarked
1,0,3,"Braund, Mr. Owen Harris",male,22,1,0,A/5 21171,7.25,C85,S
2,1,1,"Cumings, Mrs. John Bradley (Florence Briggs Thayer)",female,38,1,0,PC 17599,71.2833,C85,C
3,1,3,"Heikkinen, Miss. Laina",female,26,0,0,STON/O2. 3101282,7.925,C85,S
4,1,1,"Futrelle, Mrs. Jacques Heath (Lily May Peel)",female,35,1,0,113803,53.1,C123,S
5,0,3,"Allen, Mr. William Henry",male,35,0,0,373450,8.05,C85,S
6,0,3,"Moran, Mr. James",male,,0,0,330877,8.4583,C85,Q
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
PassengerId,Survived,Pclass,Name,Sex,Age,SibSp,Parch,Ticket,Fare,Cabin,Embarked
1,0,3,"Braund, Mr. Owen Harris",male,22,1,0,A/5 21171,7.25,C85,S
2,1,1,"Cumings, Mrs. John Bradley (Florence Briggs Thayer)",female,38,1,0,PC 17599,71.2833,C85,C
3,1,3,"Heikkinen, Miss. Laina",female,26,0,0,STON/O2. 3101282,7.925,C85,S
4,1,1,"Futrelle, Mrs. Jacques Heath (Lily May Peel)",female,35,1,0,113803,53.1,C123,S
5,0,3,"Allen, Mr. William Henry",male,35,0,0,373450,8.05,C85,S
6,0,3,"Moran, Mr. James",male,20,0,0,330877,8.4583,C85,Q
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@



import pandas as pd
import pytest
from qa_training.domain.service_make_features import ServiceMakeFeatures
from qa_training.utils.my_assert_frame_equal import MyAssert


@pytest.fixture()
def fixture_run():
service = ServiceMakeFeatures()
df_customer_info = pd.read_csv("tests/qa_training/domain/service_make_features/missing_values/df_customer_info.csv")
df_filled_expected = pd.read_csv("tests/qa_training/domain/service_make_features/missing_values/df_filled_expected.csv")

return service, df_customer_info, df_filled_expected


def test_run(fixture_run):
# Arrange
service, df_customer_info, df_filled_expected = fixture_run

# Act
df_filled = service._handle_missing_values(df_customer_info=df_customer_info)

# Assert
MyAssert().assert_df(df_filled, df_filled_expected)
49 changes: 0 additions & 49 deletions tests/qa_training/domain/test_service_make_features.py

This file was deleted.