[WEB-3614] fix: cmd-k items

[anmolsinghbhatia]

Description

This PR fixes an issue in the Command + K menu where hovering over an item and using the up/down arrow keys simultaneously caused two selections to appear.

Type of Change

• Bug fix

Media

Before	After

References

[WEB-3614]

Summary by CodeRabbit

• Style
  • Updated the command interface so that interactive items now highlight on focus instead of on hover.
  • Adjusted visual feedback for disabled items to trigger on focus rather than hover.

[coderabbitai]

Walkthrough

The update modifies the CSS for command palette items by replacing hover states with focus states for [cmdk-item] elements. This change applies to both regular and disabled elements (using aria-disabled="true" and data-disabled="true"), so that background color changes now occur on focus rather than on hover events.

Changes

File	Change Summary
web/styles/command-pallette.css	Replaced hover state selectors with focus state selectors for [cmdk-item] elements, including adjustments for disabled items.

Suggested labels

🎨UI / UX

Suggested reviewers

• sriramveeraghanta
• prateekshourya29

Poem

Oh, how I hop in gleeful delight,
As commands now shine with focus bright.
No more a hover, but a purposeful view,
Each style refined and ever so new.
A rabbit's cheer for code that's true!

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[makeplane]

Pull Request Linked with Plane Work Items

References

• [WEB-3614] Command+k gives two selections

Comment Automatically Generated by Plane

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

web/styles/command-pallette.css (1)

48-51: Consistent Focus Styling for Disabled Elements
Applying a focus state on disabled items with [aria-disabled="true"] and [data-disabled="true"] maintains consistent feedback during keyboard navigation. Consider reviewing whether additional visual indicators (like an outline) might be helpful for accessibility when these items receive focus.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dbdf2f0 and 747f415.

📒 Files selected for processing (1)

• web/styles/command-pallette.css (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (python)

🔇 Additional comments (1)

web/styles/command-pallette.css (1)

33-35: Shift to Focus State for Command Items
The change from a hover state to a focus state for [cmdk-item] is well targeted to resolve the dual selection bug when navigating with arrow keys. This ensures that only the focused item shows the background change, preventing conflicting selections from simultaneous hover events.