Skip to content

[PAI-785] fix: custom select auto close on select #7924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: preview
Choose a base branch
from
+7 −2
Draft

[PAI-785] fix: custom select auto close on select #7924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61ee99c
fix: custom select auto close on select
gakshita Oct 8, 2025
a405c14
fix: added custom prop for closeOnSelect
gakshita Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/ui/src/dropdowns/custom-select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ const CustomSelect = (props: ICustomSelectProps) => {
optionsClassName = "",
value,
tabIndex,
closeOnSelect = true,
} = props;
// states
const [referenceElement, setReferenceElement] = useState<HTMLButtonElement | null>(null);
Expand Down Expand Up @@ -60,7 +61,10 @@ const CustomSelect = (props: ICustomSelectProps) => {
ref={dropdownRef}
tabIndex={tabIndex}
value={value}
onChange={onChange}
onChange={(val) => {
onChange?.(val);
if (closeOnSelect) closeDropdown();
}}
className={cn("relative flex-shrink-0 text-left", className)}
onKeyDown={handleKeyDown}
disabled={disabled}
Expand All @@ -71,7 +75,7 @@ const CustomSelect = (props: ICustomSelectProps) => {
<button
ref={setReferenceElement}
type="button"
className={`flex items-center justify-between gap-1 text-xs ${
className={`flex items-center justify-between gap-1 text-xs rounded ${
disabled ? "cursor-not-allowed text-custom-text-200" : "cursor-pointer hover:bg-custom-background-80"
} ${customButtonClassName}`}
onClick={toggleDropdown}
Expand Down
1 change: 1 addition & 0 deletions packages/ui/src/dropdowns/helper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export interface ICustomSelectProps extends IDropdownProps {
children: React.ReactNode;
value: any;
onChange: any;
closeOnSelect?: boolean;
}

interface CustomSearchSelectProps {
Expand Down
Loading