feat: sites vite migration #7965
Conversation
…Router components
…e unnecessary optimizeDeps configuration in vite.config
Merge branch 'preview' of github.com:makeplane/plane into feat/admin-react-router-migration
- Removed unused dependencies from `apps/admin/package.json`. - Added and updated dependencies in `packages/propel`, `packages/services`, and `packages/ui` to ensure consistency and compatibility. - Cleaned up `pnpm-lock.yaml` to reflect the changes in dependencies.
…react-router-migration
- Introduced React Router for improved routing capabilities. - Refactored multiple components to align with the new routing structure. - Added new assets and configuration files for enhanced functionality. - Updated ESLint and TypeScript configurations for better type handling. - Removed deprecated files and streamlined the project structure. - Enhanced Dockerfile and Nginx configuration for optimized deployment.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| } | ||
|
|
||
| export function notFound(): never { | ||
| throw new Error("Not found"); |
There was a problem hiding this comment.
@prateekshourya29 did you check that this works as expected? I would of expected you to throw a Response instead.
| }; | ||
|
|
||
| // TODO: Convert into SSR in order to generate metadata | ||
| export async function generateMetadata({ params }: Props) { |
There was a problem hiding this comment.
@prateekshourya29 should convert to meta function the args are exported via the react-router types that are generated. You can look at my other PR for details.
| const { anchor } = params; | ||
| const IssuesPage = observer(() => { | ||
| // params | ||
| const params = useParams<{ anchor: string }>(); |
There was a problem hiding this comment.
params already come from the Route.ComponentProps and its type safe too so you don't need this
| "use client"; | ||
|
|
||
| import type { FC, FormEvent } from "react"; | ||
| import type { FormEvent } from "react"; |
There was a problem hiding this comment.
if you're getting rid of FC might as well get rid of FormEvent too.
lifeiscontent
force-pushed
the
feat/admin-react-router-migration
branch
3 times, most recently
from
5e336af to
0eda662
Compare
2 participants
Description
Type of Change