Skip to content

controller: use link.delay_override to set isis metric when in valid range #2078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

controller: use link.delay_override to set isis metric when in valid range #2078

wants to merge 2 commits into from

Conversation

@nikw9944
Copy link
Contributor

@nikw9944 nikw9944 commented Nov 5, 2025 •
edited
Loading

Summary of Changes

  • controller: use link.delay_override to set isis metric when in valid range
  • Add delay override field to link in Go SDK
  • Provides a simple workflow for contributors to temporarily change a link's delay value without overwriting the existing value

Testing Verification

  • Add links to controller unit tests
  • Add link to e2e tests with delay override set to verify behavior end-to-end

@nikw9944 nikw9944 linked an issue Nov 5, 2025 that may be closed by this pull request
controller: use link.delay_override to set isis metric when set in valid range #2073
Open
@nikw9944 nikw9944 self-assigned this Nov 5, 2025
@nikw9944 nikw9944 marked this pull request as ready for review November 5, 2025 19:39
@nikw9944 nikw9944 changed the title controller: use link.delay_override to set isis metric when set in valid range controller: use link.delay_override to set isis metric when in valid range Nov 5, 2025
packethog
packethog reviewed Nov 6, 2025
View reviewed changes
elitegreg
elitegreg approved these changes Nov 7, 2025
View reviewed changes
Copy link
Contributor

@elitegreg elitegreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elitegreg elitegreg elitegreg approved these changes

@packethog packethog packethog approved these changes

@ben-malbeclabs ben-malbeclabs Awaiting requested review from ben-malbeclabs

Assignees

@nikw9944 nikw9944

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

controller: use link.delay_override to set isis metric when set in valid range

4 participants

@nikw9944 @elitegreg @packethog