client/daemon: initial route liveness probing #2092
+3,777
−2,223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snormore
force-pushed
the
snor/client-route-liveness-bfd
branch
8 times, most recently
from
0ef86ac to
7e86765
Compare
packethog
requested changes
Nov 10, 2025
| // UnmarshalControlPacket parses a 40-byte control message from the wire | ||
| // into a ControlPacket. It validates the version and length fields and | ||
| // extracts all header values using big-endian order. | ||
| func UnmarshalControlPacket(b []byte) (*ControlPacket, error) { |
Contributor
There was a problem hiding this comment.
nit: any reason to not call these Read and Write methods?
Contributor
Author
There was a problem hiding this comment.
You mean ReadControlPacket([] byte) and p.Write()?
How about something like ParseControlPacket([] byte) and p.ToBytes()?
| for _, s := range m.sessions { | ||
| s.mu.Lock() | ||
| prev := s.state | ||
| s.state = StateAdminDown |
Contributor
There was a problem hiding this comment.
Am I understanding this admin down scenario correctly:
- The local state of all sessions are set to admin down
- These sessions will then be skipped in the tx/rx portion of the scheduler
- Since no control packets are being processed or sent, the remote endpoints will implicitly notice the admin down event due to timeouts, thus remove their local route
Contributor
Author
There was a problem hiding this comment.
Yeah exactly, on the peer-side their session ends up as just a down. On the local-side it's in admin_down state.
Admin down can be for individual routes/sessions too, doesn't have to be all.
snormore
force-pushed
the
snor/client-route-liveness-bfd
branch
from
393ece8 to
aa71f39
Compare
snormore
force-pushed
the
snor/client-route-liveness-bfd
branch
from
aa71f39 to
58e3d6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
doublezerodthat continuously validates BGP-learned routes via UDP probes using a BFD-like protocol, dynamically installing or withdrawing them from the kernel routing table based on observed reachability.tools/upingpackage that was added for previous ICMP-based implementation.Testing Verification