build: Refactor macos-* CMake presets
#2765
Merged
+15
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Jerphanion <[email protected]>
jjerphan
force-pushed
the
build/refactor-macos-presets
branch
from
95f5af9 to
744a7f7
Compare
Signed-off-by: Julien Jerphanion <[email protected]>
jjerphan
requested review from
IvoDD,
alexowens90 and
poodlewars
as code owners
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
vasil-pashov
approved these changes
Nov 20, 2025
maxim-morozov
approved these changes
Nov 20, 2025
alexowens90
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement or fix?
darwin-*andmacos-*presets are used for building ArcticDB forosx-64(x86) andosx-arm64.This is confusing, and there's no specific need for having different sets of presets.
Currently:
macos-*presets are only used for the PyPI builds and a specific deployment target seems to be needed for themdarwin-*presets are only used for the conda-forge builds (conda-forge already takes care about specific target for the ecosystem and also builds for both architectures)This refactors the presets removing
darwinpresets in preference of themacos-*presets while keeping CMake the settings unchanged for each configuration (PyPI wheels and conda packages).Any other comments?
Checklist
Checklist for code changes...