Skip to content

show full stdout for errored notebooks #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

show full stdout for errored notebooks #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions notebooker/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,10 @@ class NotebookResultError(NotebookResultBase):

@property
def raw_html(self):
return """<p>This job resulted in an error: <br/><code style="white-space: pre-wrap;">{}</code></p>""".format(
self.error_info
formatted_stdout = "<br/>".join(self.stdout) if self.stdout else ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a screenshot of this working? I had a suspicion that self.stdout wasn't populated for errors for some reason.

return """<p>This job resulted in an error: <br/><code style="white-space: pre-wrap;">{}</code></p>
<p><b>stdout</b></p><code>{}</code>""".format(
self.error_info, formatted_stdout
)

@property
Expand Down