docs(tui): align frontend protocol references on stack - #10260
Open
lawrencecchen wants to merge 2 commits into
Open
docs(tui): align frontend protocol references on stack#10260lawrencecchen wants to merge 2 commits into
lawrencecchen wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
162c188fe244Base and history
162c188fe24455a95a108879a355f52f358496d61d9552e6e6cb8d6eb982Verification
actionlintNo merge, tag, package publication, or build was performed.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Aligns TUI frontend README protocol references to v12 and adds a CI test that prevents version drift. Previously READMEs cited v7/v10 with no check; now they cite v12 and the spec workflow fails if docs diverge from the supported wire API.
cmux-tui/scripts/test_frontend_docs.pyto assert thatSUPPORTED_PROTOCOLin the web frontend,cmux-tui/docs/protocol.md, and all frontend READMEs reference the same protocol version..github/workflows/cmux-tui-spec.yml.Rollout
SUPPORTED_PROTOCOL,cmux-tui/docs/protocol.md, and README protocol lines; CI will fail if they are inconsistent.Written for commit cb8d6eb. Summary will update on new commits.