Fix INTERNAL iOS Ghostty startup crash - #10279
Open
azooz2003-bit wants to merge 1 commit into
Open
Conversation
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches 💡 1⚔️ Resolve merge conflicts 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the cmux INTERNAL TestFlight crash from August 2, 2026, where build
20260801151612crashed inghostty_init + 1388while the main thread was insetlocalefromGhosttyRuntime.init.Bumps the ghostty submodule to
f0f8273b7(manaflow-ai/ghostty@f0f8273, already on fork main), which movesensureLocale()andsyncEnviron()insrc/global.zigbefore crash-reporting init. Darwin'ssetlocalemutates global libc state; Sentry's crash-reporting init starts a background thread, and during embedded (iOS) startup that thread raced the process-wide locale mutation. Ordering locale setup before any Ghostty-owned background thread starts removes the race.This is a principled fix (initialization ordering, not a workaround).
docs/ghostty-fork.mdis updated with the fork-change entry and a conflict note to preserve the ordering in futureglobal.initmerges.🤖 Generated with Claude Code