Skip to content

fix: typescript return null #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erichbehrens
Copy link

@erichbehrens erichbehrens commented Apr 10, 2025

These methods can return null, but the typing is wrong, which prevents typescript/eslint to perform proper validation. For instance, the following code does not pass the @typescript-eslint/no-unnecessary-condition rule.

if (oidcService.getAccessToken() === null) { ... }

Unnecessary conditional, the types have no overlap.ESLint[@typescript-eslint/no-unnecessary-condition]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant