feat: show close reason in issue detail view#63
Open
TPreece101 wants to merge 2 commits intomantoni:mainfrom
Open
feat: show close reason in issue detail view#63TPreece101 wants to merge 2 commits intomantoni:mainfrom
TPreece101 wants to merge 2 commits intomantoni:mainfrom
Conversation
Display the close_reason field in the Properties sidebar of the issue detail view, between Status and Priority. Only shown when close_reason is present (truthy). Closes mantoni#34. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
TPreece101
force-pushed
the
feat/show-close-reason
branch
from
d9e5905 to
f82916d
Compare
Owner
|
Please fix the failing build. |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
I think that should fix it 😄 |
There was a problem hiding this comment.
Pull request overview
This PR adds display of the close_reason field in the issue detail view's Properties sidebar, addressing issue #34 where closed issues didn't show why they were closed. The field is conditionally rendered only when a close reason is present.
Changes:
- Added
close_reasonto theIssueTypeScript interface and theIssueDetailJSDoc typedef - Conditionally renders a "Close Reason" row in the properties sidebar between Status and Priority
- Added two tests covering the presence and absence of the close reason field
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
types/subscriptions.ts |
Added close_reason?: string | null to the Issue interface |
app/views/detail.js |
Added close_reason to JSDoc typedef and conditional rendering in the properties sidebar |
app/views/detail.test.js |
Two new tests verifying close reason renders when present and is hidden when absent |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| * @property {string} [acceptance] | ||
| * @property {string} [notes] | ||
| * @property {string} [status] | ||
| * @property {string} [close_reason] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
close_reasonin the Properties sidebar of the issue detail view, between Status and Priorityclose_reasonis truthy (hidden for open issues or closed issues without a reason)list-adapters.jsCloses #34
Changes
types/subscriptions.ts— addedclose_reasontoIssueinterfaceapp/views/detail.js— addedclose_reasontoIssueDetailtypedef and conditional render in properties sidebarapp/views/detail.test.js— 2 new tests: renders when present, hidden when absentTest plan
npm test)🤖 Generated with Claude Code